Oved Ourfali has submitted this change and it was merged. Change subject: core: Refactor VdsStatic to use FenceProxySourceType ...................................................................... core: Refactor VdsStatic to use FenceProxySourceType 1. Makes conversions between comma separated string and List<FenceProxySourceType> part of DAOs 2. Refactors *PmProxyPreferences() methods to use new *FenceProxySources() methods in VDS/VdsStatic 3. Fixes HostMapperTest.testRoundtrip() to not fill in invalid fence proxy sources into Host entity as a part of the test. Change-Id: I584ea587842cb8c4e31fa387d235d42cabea5648 Bug-Url: https://bugzilla.redhat.com/1182510 Signed-off-by: Martin Perina <mperina(a)redhat.com&gt; --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java 5 files changed, 45 insertions(+), 15 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I584ea587842cb8c4e31fa387d235d42cabea5648 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com&gt; Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com&gt; Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com&gt; Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com&gt; Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com&gt; Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server