Allon Mureinik has submitted this change and it was merged. Change subject: core: ImagesHandler.checkDiskImages with multi-SDs ...................................................................... core: ImagesHandler.checkDiskImages with multi-SDs In the current implementation, checkDiskImages takes the first storage domain for each disk it checks. This behaviour is obviously problematic for images which exist on multiple storage domains, as the check could succeed or fail based solely on the order the domains appear in the disk's data member. This patch changes the logic to accumulate ALL of the domains of all the images, for a more meaningful behaviour. Looking forward, this change will enable using checkDiskImages for template disks correctly, even though all the current use cases are VM usecases, which implies a single domain per disk. Thus, this patch preserves the current behaviour, but allows additional future usecases. Change-Id: I61b729bdcbd3001d371fb58a6358172b07be94f4 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61b729bdcbd3001d371fb58a6358172b07be94f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com>