Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Display warning before overtaking spice console ...................................................................... engine: Display warning before overtaking spice console This patch adds a displaying popup window when an user is overtaking (Spice or VNC) console that has been already in use. The popup window is displayed if these conditions hold: - "allow console reconnect" feature is disabled - there is a user currently connected to the console and following conditions hold: - the user currently connected to the console is different from the user who is trying to connect - the user currently connected to the console has not permissions to reconnect (steal) console Changes on backend: - Added command for checking whether an ad element has permission that allows console reconnect. - Removed UpdateVmConsoleData command and parameters. This command served only for unsetting console user on console disconnect. This is done by VdsEventListener. - Removed console related fields from VdsUpdateRuntimeInfo. Changes on frontend: - Added methods for checking safeness of console connecting operation and displaying confirm popup. Change-Id: Iffce89a0c7bdd0cccb71943f398f0f907fbed002 Signed-off-by: Frantisek Kobzik <fkobzik@redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=868297 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CanUpdateFieldGenericQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HasAdElementReconnectPermissionQuery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmConsoleDataCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVmConsoleDataParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/HasAdElementReconnectPermissionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 14 files changed, 191 insertions(+), 112 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffce89a0c7bdd0cccb71943f398f0f907fbed002 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com>