Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Added vertical scrolling to BaseListModelSuggestBox
......................................................................
webadmin: Added vertical scrolling to BaseListModelSuggestBox
All suggest boxes in the system could probably use a height limitation
for their suggestion list, with a vertical scrollbar when the content
is too big.
Also took the chance to move the logic fitting the height of the
suggestion list to that of the content from ListModelTypeAheadListBox
to BaseListModelSuggestBox, as ListModelSuggestBox could also use it.
Change-Id: I9c662e3e8d1062e654f10ce275019c28b62f2666
Bug-Url:
https://bugzilla.redhat.com/1008523
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.ui.xml
2 files changed, 15 insertions(+), 8 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/19791
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c662e3e8d1062e654f10ce275019c28b62f2666
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server