From Tal Nisan <tnisan@redhat.com>:

Tal Nisan has submitted this change and it was merged. Change subject: backend: change Discard After Delete logic ...................................................................... backend: change Discard After Delete logic Up until now, DAD (Discard After Delete) [1] was not related to Pass Discard [2], i.e a disk was first discarded before it was deleted only if its block storage domain's DAD value was true. That created a situation where a vm disk that had its Pass Discard enabled was not discarded before it was deleted if its storage domain's DAD value was disabled. This situation does not make sense because if the user specifies that he wants "live" discarding (Pass Discard), he will most likely want to discard the whole disk before it's deleted. This patch fixes the DAD logic so that a disk will be discarded before it's deleted if DAD is enabled for its storage domain, or if the same disk is attached to at least one vm with its Pass Discard enabled. [1] http://www.ovirt.org/develop/release-management/features/storage/discard-aft... [2] http://www.ovirt.org/develop/release-management/features/storage/pass-discar... Change-Id: I06345cd0cebed0ee4ad9ccc930e978807ab47f11 Bug-Url: https://bugzilla.redhat.com/1427543 Signed-off-by: Idan Shaby <ishaby@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/PostDeleteActionHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/PostDeleteActionHandlerTest.java 2 files changed, 78 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/73164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06345cd0cebed0ee4ad9ccc930e978807ab47f11 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>