Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Fix condition in "IconHelper" ...................................................................... restapi: Fix condition in "IconHelper" This is needed in order to avoid the following findbugs warning, but it also looks like a real bug: Repeated conditional tests The code contains a conditional test is performed twice, one right after the other (e.g., x == 0 || x == 0). Perhaps the second occurrence is intended to be something else (e.g., x == 0 || y == 0). Bug kind and pattern: RpC - RpC_REPEATED_CONDITIONAL_TEST Change-Id: I329dc96c77cd91c175fea8cb70580605dc062782 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> Bug-Url: https://bugzilla.redhat.com/1265716 (cherry picked from commit 044b9a131d22496468cbc5e07909d6fbda1bed74) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/IconHelper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46830 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I329dc96c77cd91c175fea8cb70580605dc062782 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski@gmail.com> Gerrit-Reviewer: automation@ovirt.org