Oved Ourfali has submitted this change and it was merged. Change subject: core: Fix entity manager scope ...................................................................... core: Fix entity manager scope EntityManager had a too large scope when using it through DbFacade. Change-Id: I1e4962a0dbb7ae585181a0a9b390f86679ba07ac Bug-Url: https://bugzilla.redhat.com/1159621 Signed-off-by: lzelkha@redhat.com <lzelkha@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Step.java M backend/manager/modules/dal/pom.xml M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BookmarkDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EngineBackupLogDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobSubjectEntityDaoFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StepDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/AbstractJpaDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/EntityManagerHolder.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/TransactionalInterceptor.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/EntityManagerTestListener.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDaoTestCase.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseHibernateDaoTestCase.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DaoCdiIntegrationTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StepDaoTest.java M backend/manager/modules/dal/src/test/resources/test-beans.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/transaction/Transactional.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/transaction/TransactionalInterceptor.java 19 files changed, 280 insertions(+), 141 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Liran Zelkha: Verified Moti Asayag: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43072 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e4962a0dbb7ae585181a0a9b390f86679ba07ac Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzelkha@redhat.com> Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits@redhat.com> Gerrit-Reviewer: automation@ovirt.org