Moti Asayag has submitted this change and it was merged.
Change subject: backend: Move noop ProviderProxy method impls to interface defaults
......................................................................
backend: Move noop ProviderProxy method impls to interface defaults
Great majority of ProviderProxy implementationd contained noop (or
null-returning) implementation of getCertificateChain(), onAddition(),
onModification() and onRemoval() methods.
These were extracted using Java8 default methods to the ProviderProxy interface
itself, resulting in reduction of trivial boilerplate methods.
Change-Id: If2e869a9cf1df3c6db0c720e54552bfb9c07cfd3
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderProxy.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/AbstractOpenStackStorageProviderProxy.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageProviderProxy.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackVolumeProviderProxy.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/vms/KVMVmProviderProxy.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/vms/VmwareVmProviderProxy.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/vms/XENVmProviderProxy.java
9 files changed, 12 insertions(+), 106 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Martin Betak: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/60739
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2e869a9cf1df3c6db0c720e54552bfb9c07cfd3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>