Itamar Heim has submitted this change and it was merged. Change subject: backend: remove vm check from LiveMigrateDiskCommand ...................................................................... backend: remove vm check from LiveMigrateDiskCommand This patch shifts the VM status check from the LiveMigrateDiskCommand to VmReplicateDiskStartTaskHandler. This will: * prevent CreateImagePlaceholderTaskHandler from failing if the VM crashes during its execution * shift the failure to the appropriate handler (VmReplicateDiskStart) * allow the CreateImagePlaceholderTaskHandler compensation to take place and remove the destination image when necessary Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=957703 Change-Id: Iac42a5d10373a0c1fcf9a224fb902f0ce481d3b7 Signed-off-by: Federico Simoncelli <fsimonce@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskStartTaskHandler.java 2 files changed, 12 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac42a5d10373a0c1fcf9a224fb902f0ce481d3b7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Federico Simoncelli <fsimonce@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce@redhat.com> Gerrit-Reviewer: Itamar Heim <iheim@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server