Michael Kublin has submitted this change and it was merged. Change subject: engine: Remove a dead code from VdsManager ...................................................................... engine: Remove a dead code from VdsManager The following condition was removed from VdsManager because it will never be true. _vdsUpdater is cleaned usually before realising a lock inside a VdsManager and exit of critical section. The method UpdateVmDynamic is usually called under lock of VdsManger, so always _vdsUpdater will be null. The method from VdsUpdateRuntimeInfo not in use anymore - that's why removed. Change-Id: Ib79757485afc1cdcb505b10030b68c0d15a50fdb Signed-off-by: Michael Kublin <mkublin@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 2 files changed, 0 insertions(+), 13 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib79757485afc1cdcb505b10030b68c0d15a50fdb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>