Gilad Chaplik has submitted this change and it was merged. Change subject: engines: improve data integrity in remove quota (#848816) ...................................................................... engines: improve data integrity in remove quota (#848816) https://bugzilla.redhat.com/848816 Problem: - with the enable of multiple quota in a single remove the possibility for concurrency problems increase. - if after the quota was removed from the cache and before it is removed from the database it is accessed it may be loaded in to the cache and stay there until it is removed once more. Solution: - switched the order of execution, first remove from DB and the from cache now the operation cannot end in an inconsistent state Change-Id: Ic9850db0041b7106c5a938b2089f4641235ea814 Signed-off-by: Noam Slomianko <nslomian@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveQuotaCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7505 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9850db0041b7106c5a938b2089f4641235ea814 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server