Allon Mureinik has submitted this change and it was merged. Change subject: core: Add tests for isStorageDomainNotInAnyPool() ...................................................................... core: Add tests for isStorageDomainNotInAnyPool() StorageDomainToPoolRelationValidartor#isStorageDomainNotInAnyPool() used to be tested indirectly (read: wrongly) in RemoveStorageDomainCommandTest. This wrong behavior was removed in a87cfdf6cedeaadb8fd3b69dd7567f581348414f, which, in spite of being correct in its own right, had the unfortunate side effect of losing some test coverage. This patch introduces new tests for the methods we lost coverage on, in the right place this time. Change-Id: I7ed344b8e6e8e1a29f0417a5a8f5a7c82ff06086 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainToPoolRelationValidatorTest.java 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Looks good to me, but someone else must approve Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43610 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ed344b8e6e8e1a29f0417a5a8f5a7c82ff06086 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org