Michael Kublin has submitted this change and it was merged. Change subject: core: Removing TransactiveAttribute and appropriate logic ...................................................................... core: Removing TransactiveAttribute and appropriate logic The following attribute was used in order to perform a rollback at case of failure inside Vds commands. The following approach was used only at one command AddNetworkVDSCommand correctly and was used incorrect at IrsCreateCommand and ConnectStorageServerVDSCommand. Also, we should not perform a rollback inside of vds command , a rollback should be done from BL commands or any other BL manager. Also, the Vds commands should be run outside scope of transaction, it is mean that the transactional rollback is not relevant for them. Change-Id: I12638ee4c27d8548fc5e1a3212ec4541507fd023 Signed-off-by: Michael Kublin <mkublin@redhat.com> --- D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/TransactiveAttribute.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcCommandBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsCreateCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/AddNetworkVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java 5 files changed, 7 insertions(+), 68 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12638ee4c27d8548fc5e1a3212ec4541507fd023 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>