Liron Aravot has submitted this change and it was merged. Change subject: core: avoid connect to the same target multiple times ...................................................................... core: avoid connect to the same target multiple times When querying for the storage server connections of a VG, there's no need to return the same connection multiple times if the it's the same to avoid multiple operations on engine and on vdsm side. As we currently have one session for target, so this shouldn't cause to regression while eliminating unneeded operations. before: ------- engine: START, ConnectStorageServerVDSCommand connectionList = [{ id: 1212f182-9593-4cef-8c98-a3e99bf29fa2... }; { id: 1212f182-9593-4cef-8c98-a3e99bf29fa2... }; { id: 1212f182-9593-4cef-8c98-a3e99bf29fa2, ... };]), vdsm: Run and protect: connectStorageServer, Return response: {'statuslist': [{'status': 0, 'id': '1212f182-9593-4cef-8c98-a3e99bf29fa2'}, {'status': 0, 'id': '1212f182-9593-4cef-8c98-a3e99bf29fa2'}, {'status': 0, 'id': '1212f182-9593-4cef-8c98-a3e99bf29fa2'}]} after: ------- engine: connectionList = [{ id: 1212f182-9593-4cef-8c98-a3e99bf29fa2, ..};]) vdsm: Run and protect: connectStorageServer, Return response: {'statuslist': [{'stat us': 0, 'id': '1212f182-9593-4cef-8c98-a3e99bf29fa2'}]} Change-Id: If40ef468dc4eca4237ad824dc81aa39a90cce017 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1111994 Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/storages_san_sp.sql 4 files changed, 31 insertions(+), 3 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If40ef468dc4eca4237ad824dc81aa39a90cce017 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce@redhat.com> Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server