Tal Nisan has submitted this change and it was merged. Change subject: core: Refactored ProfileParametersBase constructor ...................................................................... core: Refactored ProfileParametersBase constructor ProfileParametersBase accepted both Profile and Id. Id can be retrieved from profile.getId() instead of as an argument in the constructor. This is bad practice and has potential for problems. So, now the constructor only accepts a profile and the id is taken from the profile itself. Methods that were using the constructor were changed inorder to comply with the new constructor arguments. Change-Id: I0b9fa9ff81422fa5a9782e847892d79f2e5e7b74 Bug-Url: https://bugzilla.redhat.com/1143869 Signed-off-by: Tomer Saban <tsaban(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/AddCpuProfileCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CpuProfileParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DiskProfileParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ProfileParametersBase.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCpuProfileResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDiskProfileResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDiskProfilesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCpuProfileResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskProfileResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/CpuProfileBaseModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/DiskProfileBaseModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/RemoveCpuProfileModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/RemoveDiskProfileModel.java 14 files changed, 22 insertions(+), 26 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, but someone else must approve Tomer Saban: Verified Roy Golan: Looks good to me, approved Phillip Bailey: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55947 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b9fa9ff81422fa5a9782e847892d79f2e5e7b74 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com&gt; Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com&gt; Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com&gt; Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;