Moti Asayag has submitted this change and it was merged. Change subject: engine: Modified fk_validator to handle composite foreign keys ...................................................................... engine: Modified fk_validator to handle composite foreign keys In case of composite foreign keys, the table_col and fk_col in the select references cursor was empty, which causes the validation to error out. for instance, if fk is on a composite primary key like this "(sched_name, trigger_name, trigger_group)" the regular expression should consider "," and space. Also,in the query to fetch violations, the inner select clause for composite keys should return multiple columns as opposed to single column - hence trimming "()" Change-Id: Ie4210537c6ef7ce7f89bd73be9e44178b6b8d43a Signed-off-by: Sahina Bose <sabose@redhat.com> --- M packaging/setup/dbutils/fkvalidator_sp.sql 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/36603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4210537c6ef7ce7f89bd73be9e44178b6b8d43a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Sahina Bose <sabose@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server