Eli Mesika has submitted this change and it was merged. Change subject: core: fix adding the right video device type (#849635) ...................................................................... core: fix adding the right video device type (#849635) https://bugzilla.redhat.com/show_bug.cgi?id=849635 when adding a new VM the console type chosen by the user (spice,vnc) should be reflected in creating appropriate underlying video device in vm_device table, i.e qxl for spice and cirrus for vnc. Verified: - Adding Server/Desktop VM with spice/vnc console from blank/other templates. - Make Template from VM - Create Vm from snapshot - Import/Export VM/Template Change-Id: I3d28d171b53eb5d44a97f0956384b1012ab5cd1f Signed-off-by: Roy Golan <rgolan@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DisplayType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java 5 files changed, 57 insertions(+), 36 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d28d171b53eb5d44a97f0956384b1012ab5cd1f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server