Daniel Erez has submitted this change and it was merged. Change subject: core: ISO domain permission error shouldn't tirgger SPM selection. ...................................................................... core: ISO domain permission error shouldn't tirgger SPM selection. Failure while executing getFloppyList command with permission error triggers DC reinitialization instead of just logging the error. GetFloppyListCommand is a IrsBrokerCommands, which means that generally an exception thrown by it would trigger a run of the failure mechanism in IrsBrokerCommand. This patch changes the default thrown exception from this commands to be an exception that doesn't trigger failover, so unless we encounter specific case SPM reselection won't be triggered. Change-Id: I4e75982d1a88dc36251d2c2e693ffafdc7a7a99e Bug-Url: https://bugzilla.redhat.com/854975 Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetFloppyListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java 4 files changed, 18 insertions(+), 8 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8690 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e75982d1a88dc36251d2c2e693ffafdc7a7a99e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Ayal Baron <abaron@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com>