Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Verify iSCSI username and password length ...................................................................... packaging: setup: Verify iSCSI username and password length Verify that iSCSI username length is equal or less to the ovirt_hosted_engine_setup.constants.Const.MAX_STORAGE_USERNAME_LENGTH (Currently set to 50 characters). Also verify that iSCSI password length is equal or less to the ovirt_hosted_engine_setup.constants.Const.MAX_STORAGE_PASSWORD_LENGTH (Currently also set to 50 characters). Please note that the values of these constants must be synced with the values defined in user_name and password fields of the storage_server_connections table. (These tables are defined in packaging/dbscripts/create_tables.sql). Note: this patch requires https://gerrit.ovirt.org/#/c/42851/ patch ('store' param support in queryEnvKey) in order to function properly. Change-Id: I74ba0a296b5c488dbf31c656f4c67fb7c79cc52e Signed-off-by: Lev Veyde <lveyde@redhat.com> Bug-Url: https://bugzilla.redhat.com/1210763 --- M ovirt-hosted-engine-setup.spec.in M src/bin/ovirt-hosted-engine-setup.env M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/storage/blockd.py 4 files changed, 60 insertions(+), 30 deletions(-) Approvals: Lev Veyde: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/42596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74ba0a296b5c488dbf31c656f4c67fb7c79cc52e Gerrit-PatchSet: 17 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi@redhat.com> Gerrit-Reviewer: automation@ovirt.org