Maor Lipchuk has submitted this change and it was merged.
Change subject: engine: Refactor Cinder Remove Disk callback
......................................................................
engine: Refactor Cinder Remove Disk callback
Use the generic callback SerialChildCommandsExecutionCallback
in RemoveCinderDiskCommand.
In RemoveCinderVolumeParentCommand, implement methods of interface
SerialChildExecutingCommand.
Change-Id: Ia26596213dcfe68aa5d88f990fbaf4d30cc6beda
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderDiskCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderVolumeParentCommand.java
2 files changed, 22 insertions(+), 2 deletions(-)
Approvals:
Freddy Rolland: Verified
Maor Lipchuk: Looks good to me, approved; Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/55622
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia26596213dcfe68aa5d88f990fbaf4d30cc6beda
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>