Arik Hadas has submitted this change and it was merged. Change subject: core: do not decrease pending resources twice on run vm ...................................................................... core: do not decrease pending resources twice on run vm We used to decrease the pending resources twice when running VM - when the VM is switched to powering-up (onPoweringUp) and when it is switched to up (runningSucceeded). The problem is that we don't update the cached field, lastDecreasedVds, so on runningSucceeded we don't know that the pending resources were already been decreased. This patch changes the pending decrement in onPoweringUp method such that the VDS we are decrementing the pending resources from will be cached. Change-Id: Ie73f98504ae61ec20a722501fdd49930892dd80a Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 4 files changed, 9 insertions(+), 8 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/35669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie73f98504ae61ec20a722501fdd49930892dd80a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server