Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix client sorting for size columns ...................................................................... webadmin: fix client sorting for size columns Currently, size columns are sorted using LexoNumericComparator, which is fine for most cases except for '< 1 GB' value... Hence, overridden 'makeSortable' method to compare the size values numerically. Screenshot: http://i.imgur.com/KfJjdq8.png Change-Id: Iab8cdc171ff8f652ec0747212f6fd846cf95540e Bug-Url: https://bugzilla.redhat.com/1133264 Signed-off-by: Daniel Erez <derez@redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractSizeColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskSizeColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StorageSizeColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java 4 files changed, 31 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/31920 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab8cdc171ff8f652ec0747212f6fd846cf95540e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server