Change in ovirt-engine[master]: backend: overload VdsCommandsHelper::getHostForExecution

From Allon Mureinik <amureini@redhat.com>:
Allon Mureinik has submitted this change and it was merged. Change subject: backend: overload VdsCommandsHelper::getHostForExecution ...................................................................... backend: overload VdsCommandsHelper::getHostForExecution Whoever uses getHostForExecution and doesn't care about the returned vds ID shouldn't care about the inner implementation of it (shall it get null or an empty list?). The right way of solving this is simply overload this method without the hostsToFilter argument. Change-Id: I2cfd17f41299dc0b661a84d4c3b7a0d5c95db749 Signed-off-by: Idan Shaby <ishaby@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/utils/VdsCommandsHelper.java 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/78271 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cfd17f41299dc0b661a84d4c3b7a0d5c95db749 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
Code Review