Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: asynctasks: do not start/stop engine ...................................................................... packaging: setup: asynctasks: do not start/stop engine async tasks handling/cleanup during setup/upgrade is protected from adding additional tasks by moving the engine to "maintenance mode". Without this patch, we also try to start the engine when setting maintenance mode, and stop it when we finish. This breaks the migration flow described in the referenced bug, where we run setup of version X where engine of version X is already installed, but the database is from an older version. In this flow, we do not want to start the newer engine to run against an older database. It's also ugly in other ways: In a normal upgrade, if the engine was up, we needlessly try to start it. Later on, this code takes the engine down, while we immediately try doing that again (at transaction begin). Stop doing that. Just set maintenance mode in the database and expect the engine to behave accordingly, if it's up. If the engine is down, and there are pending tasks, notify the user accordingly. This is a cherry-pick of 9736573f2fc1b60e48c2fa64dafc2f3d1088338a. The flow described above does not apply exactly, as we are supposed to be in same version of application, but different OS. So we still do not want to start the engine. Change-Id: I4f9d31dbb6b748ac3c49ceb7d7d2b53cbd6d38df Bug-Url: https://bugzilla.redhat.com/1332463 Signed-off-by: Yedidyah Bar David <didi@redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py 1 file changed, 17 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/56969 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f9d31dbb6b748ac3c49ceb7d7d2b53cbd6d38df Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.6 Gerrit-Owner: Yedidyah Bar David <didi@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi@redhat.com>