Change in ovirt-engine-sdk[master]: Use DiskAttachment.active explicitly

From Ondra Machacek <omachace@redhat.com>:
Ondra Machacek has submitted this change and it was merged. Change subject: Use DiskAttachment.active explicitly ...................................................................... Use DiskAttachment.active explicitly The 'DiskAttachment.active' attribute isn't mandatory when adding a disk attachment to a virtual machine, but if it isn't provided the result is undefined: the disk will be active in some situations, and won't in some other situations. To avoid that uncertainty it is better to always include it with the desired value. This patch changes the examples accordingly. Change-Id: Icedc9fe74c2bc00cd158b66e81d478d273a4b605 Related-To: https://bugzilla.redhat.com/1390517 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> --- M sdk/examples/add_vm_disk.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66340 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icedc9fe74c2bc00cd158b66e81d478d273a4b605 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
Code Review