Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove GetPermittedStorageDomainsByTemplateId ...................................................................... core: Remove GetPermittedStorageDomainsByTemplateId GetPermittedStorageDomainsByTemplateIdQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetPermittedStorageDoaminsByTemplateIdQuery class 2. The GetPermittedStorageDoaminsByTemplateId constant representing it in VdcQueryType 3. The GetPermittedStorageDomainsByTemplateIdParameters class which was only used by the removed query class. 3. The getPermittedStorageDomainsById method in StorageDomainDAO (which was only used by the query), its implementation, and its test. 4. The Getstorage_domain_by_id_with_permitted_action stored procedure that was only used by the said DAO function. Change-Id: I94f586e0daeebc0f768639b39444b30ff3101378 Signed-off-by: Allon Mureinik <amureini(a)redhat.com&gt; --- M backend/manager/dbscripts/storages_sp.sql D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetPermittedStorageDomainsByTemplateIdQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetPermittedStorageDomainsByTemplateIdParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDAOTest.java 7 files changed, 3 insertions(+), 93 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94f586e0daeebc0f768639b39444b30ff3101378 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com&gt; Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com&gt;