From Greg Sheremeta <gshereme@redhat.com>:

Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80546 ) Change subject: engine / branding: introduce sass for css compilation ...................................................................... engine / branding: introduce sass for css compilation Introduce sass via libsass [1] / libsass-maven-plugin [2][3], and move ovirt.brand into a maven project in frontend/brands. Sass is a css pre-processor that brings us css compression, allows breaking up css into smaller files (called partials) without runtime performance penalties, and allows us to move away from GWT css solutions (whereby css ends up baked into generated JavaScript). Follow-up patches will convert our current css files to well- structured and organized sass files, using partials, variables, etc. [1] https://github.com/sass/libsass [2] https://mvnrepository.com/artifact/com.github.warmuuh/libsass-maven-plugin/ [3] https://github.com/warmuuh/libsass-maven-plugin libsass is platform-specific, written in C/C++. The Maven plugin uses jsass [4] to interop with libsass. jsass uses the "git submodule" feature [5] to pull in libsass code, effectively avoiding the platform-specific dependency on libsass. Therefore, jsass is self-contained Sass impl. that contains all platform-specific libs (Windows .dll, Linux .so, etc.) in its distributable JAR file. [4] https://github.com/bit3/jsass [5] https://github.com/bit3/jsass/blob/develop/.gitmodules Change-Id: I2bb197c9d4eddf2727179aeec8a358d90e3157fa Signed-off-by: Greg Sheremeta <gshereme@redhat.com> --- M Makefile A frontend/brands/ovirt-brand/pom.xml R frontend/brands/ovirt-brand/src/main/resources/branding.properties R frontend/brands/ovirt-brand/src/main/resources/common.css R frontend/brands/ovirt-brand/src/main/resources/external_resources.properties R frontend/brands/ovirt-brand/src/main/resources/images/dialog/error.png R frontend/brands/ovirt-brand/src/main/resources/images/favicon-16x16.png R frontend/brands/ovirt-brand/src/main/resources/images/favicon-32x32.png R frontend/brands/ovirt-brand/src/main/resources/images/favicon.ico R frontend/brands/ovirt-brand/src/main/resources/images/oVirt_About_BG_Flat_Image.png R frontend/brands/ovirt-brand/src/main/resources/images/oVirt_Banner_solid.png R frontend/brands/ovirt-brand/src/main/resources/images/oVirt_Landing_Bottom_Left_Corner.png R frontend/brands/ovirt-brand/src/main/resources/images/oVirt_Landing_Top_Right_Corner.png R frontend/brands/ovirt-brand/src/main/resources/images/oVirt_Logo.png R frontend/brands/ovirt-brand/src/main/resources/images/ovirt_header_logo.png R frontend/brands/ovirt-brand/src/main/resources/images/ovirt_middle_logo_name.png R frontend/brands/ovirt-brand/src/main/resources/messages.properties R frontend/brands/ovirt-brand/src/main/resources/messages_de_DE.properties R frontend/brands/ovirt-brand/src/main/resources/messages_es_ES.properties R frontend/brands/ovirt-brand/src/main/resources/messages_fr_FR.properties R frontend/brands/ovirt-brand/src/main/resources/messages_it_IT.properties R frontend/brands/ovirt-brand/src/main/resources/messages_ja_JP.properties R frontend/brands/ovirt-brand/src/main/resources/messages_ko_KR.properties R frontend/brands/ovirt-brand/src/main/resources/messages_pt_BR.properties R frontend/brands/ovirt-brand/src/main/resources/messages_zh_CN.properties R frontend/brands/ovirt-brand/src/main/resources/ovirt-patternfly-compat.css R frontend/brands/ovirt-brand/src/main/resources/ovirt.css R frontend/brands/ovirt-brand/src/main/resources/patternfly-ovirt.css R frontend/brands/ovirt-brand/src/main/resources/resources.properties R frontend/brands/ovirt-brand/src/main/resources/web_admin.css R frontend/brands/ovirt-brand/src/main/resources/welcome_page.template R frontend/brands/ovirt-brand/src/main/resources/welcome_style.css A frontend/brands/pom.xml M frontend/pom.xml M ovirt-engine.spec.in M pom.xml 36 files changed, 100 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80546 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bb197c9d4eddf2727179aeec8a358d90e3157fa Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme@redhat.com> Gerrit-Reviewer: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>