Alona Kaplan has submitted this change and it was merged. Change subject: engine: change VmInfoBuilder network filter logic ...................................................................... engine: change VmInfoBuilder network filter logic The feature of Network filter enhancing the user ability to customize the vNIC's network filter type beside 'vdsm-no-mac-spoofing' or configurating no filter at all. Please note that vdsm will configure the mentioned 'filter' property's value as the vNIC's network filter. In case no network filter is desirable, the filter property should not be mentioned at all. The patch is modifing the engine's logic which used to un\mention the 'filter' property according to the value of 'EnableMACAntiSpoofingFilterRules' saved in vdc_options table. The option_name of 'EnableMACAntiSpoofingFilterRules' and the corresponding backend's representation is kept for backward compatibility support, specifically for Rest API scripting for determining the default network filter behavior. Please note that the use of NetworkFilterDao was without DI as it required a major refactoring of VmInfoBuilder and it should be done in a dedicated patch. Change-Id: Ie0cb0604e708adbc09dc4742c47464131357fe32 Signed-off-by: Eliraz Levi <elevi@redhat.com> Signed-off-by: Alona Kaplan <alkaplan@redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NetworkFilters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 4 files changed, 30 insertions(+), 25 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52768 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0cb0604e708adbc09dc4742c47464131357fe32 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>