Allon Mureinik has submitted this change and it was merged. Change subject: core: Introducing the comparators package ...................................................................... core: Introducing the comparators package org.ovirt.engine.core.common.businessentities includes several comparators, which aren't really business entities on their own right. This patch introduces the package org.ovirt.engine.core.common.businessentities.comparators and moves those comparators there, in order to make the project's organization more straightforward. Following patches will move additional comparators there, from other sub-projects. Change-Id: I70f2432df8338c736d9ab0e6c97e38acf3ddf92f Signed-off-by: Allon Mureinik <amureini(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearNonResponsiveVdsVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTopSizeVmsFromStorageDomainQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUserVmsByUserIdAndGroupsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesFromStorageDomainQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsRelatedToQuotaIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVMActionRunner.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/BusinessEntityComparator.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/BusinessEntityGuidComparator.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/ImagesComparerByName.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/InterfaceComparerByMAC.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmTemplateComparerByDiskSize.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparer.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparerByDiskSize.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkStatistics.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDaoDbFacadeImpl.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 21 files changed, 35 insertions(+), 20 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70f2432df8338c736d9ab0e6c97e38acf3ddf92f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com&gt; Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com&gt;