Tal Nisan has submitted this change and it was merged.
Change subject: core: fix of export without tasks and snapshot collapse
......................................................................
core: fix of export without tasks and snapshot collapse
The following patch handles the following issues:
*The loop should be performed for disks relevant to the snapshot only.
*The populated image id's list should contain only exported images.
*When exporting a vm with no created tasks and collapse, the collapse
operations should be done - otherwise we will never have the snapshots collapsed when
there are no created tasks.
*The unlock of the vm should be the last step, as otherwise the vm
configuration might change during the run and yield to inconsistent
results.
Change-Id: I1bfc2761a5483d6f0b274d064cbc7e155562573f
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
1 file changed, 3 insertions(+), 14 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/20712
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1bfc2761a5483d6f0b274d064cbc7e155562573f
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server