Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Re-selection of the same icon works in IE and Chrome

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Re-selection of the same icon works in IE and Chrome ...................................................................... webadmin: Re-selection of the same icon works in IE and Chrome In IE and Chrome <input type="file"> only fires 'change' event if the new files selection differes from the previous selection. This behaviour causes that one can't 1. select custom icons, 2. use default icon, 3. re-select the same custom icon The solution is creating new <input> tag for each upload invocation. Change-Id: I8455c45c5126409d37d3469d0b67a1c752c94f40 Bug-Url: https://bugzilla.redhat.com/1267711 Signed-off-by: Jakub Niedermertl <jniederm@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/IconEditorWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/IconEditorWidget.ui.xml 2 files changed, 17 insertions(+), 18 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46905 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8455c45c5126409d37d3469d0b67a1c752c94f40 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski@gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: automation@ovirt.org
participants (1)
-
piotr.kliczewski@gmail.com