Lior Vernia has submitted this change and it was merged. Change subject: webadmin: refactor—overgrown constructor ...................................................................... webadmin: refactor—overgrown constructor - overgrown constructor split to smaller, single purpose methods (I need to add next gui code there, and it's too long already) - make all parameters final, if they can be final, not just some. Change-Id: I05d1ec1064eb3ec4ce17f88a2d532cb76aa4f39d Signed-off-by: Martin Mucha <mmucha@redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/macpool/SharedMacPoolView.java 1 file changed, 37 insertions(+), 10 deletions(-) Approvals: Martin Mucha: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05d1ec1064eb3ec4ce17f88a2d532cb76aa4f39d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server