Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Refactor CurrentUser code ...................................................................... webadmin: Refactor CurrentUser code CurrentUser#login is typically called after UI plugins get initialized. Keeping separate DbUser reference in CurrentUser is not only redundant but also dangerous -- before CurrentUser#login executes, UI plugins will get 'null' from api.loginUserName() and api.loginUserId() functions. This patch also removes some unused methods from CurrentUser. Change-Id: I0b6998dd2bfaabd22f80fdde1c154fb2da447804 Bug-Url: https://bugzilla.redhat.com/1361656 Signed-off-by: Vojtech Szocs <vszocs@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/auth/CurrentUser.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java 2 files changed, 10 insertions(+), 24 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/61709 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b6998dd2bfaabd22f80fdde1c154fb2da447804 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>