Daniel Erez has submitted this change and it was merged. Change subject: core: commit snapshot - handle snapshots with illegal disks ...................................................................... core: commit snapshot - handle snapshots with illegal disks Added the following procedures upon committing a snapshot: * Newer snapshots (than the previewed one): mark their VM configuration as broken; since they can't be previewed anymore. * Newer snapshots (than the previewed one) with *all* disks in status Illegal: delete; since they're redundant. Change-Id: I53148e9f0fabbec8ea03e7a8b1d3cccdfa96c4a1 Bug-Url: https://bugzilla.redhat.com/1375139 Bug-Url: https://bugzilla.redhat.com/1379131 Signed-off-by: Daniel Erez <derez(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDaoImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCustomPreviewPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/snapshot/SnapshotsViewColumns.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M packaging/dbscripts/snapshots_sp.sql A packaging/dbscripts/upgrade/04_01_0680_add_vm_configuration_broken_to_snapshots.sql 15 files changed, 117 insertions(+), 33 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/68536 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53148e9f0fabbec8ea03e7a8b1d3cccdfa96c4a1 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com&gt; Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;