Arik Hadas has submitted this change and it was merged. Change subject: core: remove confusing 'stable' field from VmAnalyzer ...................................................................... core: remove confusing 'stable' field from VmAnalyzer The field called 'stable' was used to discover whether or not we should call removeVmFromCache method in updateRepository. The logic there is not trivial and buttom line is that this method is called only when the status of the reported VM is down and the VM is running on the monitored host (dbVm != null). Therefore, moving the call to be proceedDownVm. This move should have no side effects (it might not be necessary at all - but need some more investigation before removing it) and it makes the 'stable' field redundant. Change-Id: Ib4c636d11f92b6915fec03701a37f5335ef42411 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 4 insertions(+), 10 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/55631 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4c636d11f92b6915fec03701a37f5335ef42411 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>