Allon Mureinik has submitted this change and it was merged. Change subject: core: Seriazlizable DiskImage comperators ...................................................................... core: Seriazlizable DiskImage comperators Both DiskImage comperators in the dal packages were not defined as serializable, which is considered to be a good defensive approach, especially since comperators are stateless, so serializing them is practically free. This addresses the FindBugs warning SE_COMPARATOR_SHOULD_BE_SERIALIZABLE on these classes. Change-Id: I0c0474da61a9d692bc35b2cb4b6d7e9be06edd34 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/comparators/DiskImageByBootComparator.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/comparators/DiskImageByDiskAliasComparator.java 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c0474da61a9d692bc35b2cb4b6d7e9be06edd34 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin@redhat.com>