Maor Lipchuk has submitted this change and it was merged. Change subject: core: Validate Storage Domain for Importing Template from configuration ...................................................................... core: Validate Storage Domain for Importing Template from configuration For each disk in the template, we should fetch the Storage Domain and validate that it exists and active. Today, we set the storage id for each image and then use getStorageDomain method to fetch the Storage Domain with that id, but when the Storage Domain being initialized, it will always check the first Storage Domain every time. Change-Id: I2bfe3ba9b48747650291a887255e85358ed0799a Bug-Url: https://bugzilla.redhat.com/1138200 Bug-Url: https://bugzilla.redhat.com/1140560 Signed-off-by: Maor Lipchuk <mlipchuk@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java 2 files changed, 31 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/32814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bfe3ba9b48747650291a887255e85358ed0799a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server