Omer Frenkel has submitted this change and it was merged. Change subject: core: cleanup related to memory state removal ...................................................................... core: cleanup related to memory state removal 1. changed MemoryImageRemover#isMemoryStateRemovable method not to be abstract, but to have a default check that checks that the memory state representation is not empty 2. Reduce the visibility of MemoryImageRemover#removeMemoryVolumes to 'protected' as it shouldn't be invoked by external classes. subclasses expose API that use it behind the scenes 3. Snapshot manager now uses MemoryUtils#getMemoryVolumesFromSnapshots instead of having duplicated logic Change-Id: I30f400400eb8233a61c4a9cef54c7a8844255b38 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverFromExportDomain.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverOnDataDomain.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 6 files changed, 33 insertions(+), 28 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17307 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30f400400eb8233a61c4a9cef54c7a8844255b38 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server