Arik Hadas has submitted this change and it was merged. Change subject: core: Use SATA CD-ROM for q35 chipset ...................................................................... core: Use SATA CD-ROM for q35 chipset Extended os.other.devices.cdInterface option syntax in osinfo properties to be able to set different interface types (IDE, SCSI, SATA) for CD-ROM device for different chipsets. Now this option contains comma-separated list of interface types possibly prefixed with "<chipset name>/". The value without prefix is used by default, if no other value is defined for the chipset used by the VM. Change-Id: I71ef92e9d096eeadb17e64bd37e17219a07155f2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1305900 Signed-off-by: Shmuel Melamud <smelamud@redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ChipsetType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java M backend/manager/modules/utils/src/main/javacc/org/ovirt/engine/core/utils/osinfo/osinfo.jj M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M build/validations/src/test/java/org/ovirt/engine/build/validations/OsinfoValidationsTest.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M packaging/conf/osinfo-defaults.properties 9 files changed, 96 insertions(+), 22 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56588 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71ef92e9d096eeadb17e64bd37e17219a07155f2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik@redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud@redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>