Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin : Fixed allignment issues in Hosts General sub-tab ...................................................................... webadmin : Fixed allignment issues in Hosts General sub-tab The rows in Hosts General sub-tab were not alligned properly as each of them were of a different type of label. ex : 1. TextBoxLabel were generating a input-class for the values. 2. Other labels(inheriting ValueLabel) were generating a span tag. So,this patch makes it uniform by replacing all ValueLabel by TextBoxLabelBase and its derivatives and hence fixes all the row allignment issues in Host->General. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1031596 Change-Id: Iba34398f6972f90d81d76196e060c9184665dd22 Signed-off-by: Anmol Babu <anbabu@redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/BooleanTextBoxLabel.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/EnumTextBoxLabel.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/MemorySizeTextBoxLabel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/DetailsLabel.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/DetailsTextBoxLabel.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/NullableNumberTextBoxLabel.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/PercentTextBoxLabel.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/VersionTextBoxLabel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/DetailsRenderer.java 10 files changed, 142 insertions(+), 58 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba34398f6972f90d81d76196e060c9184665dd22 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu@redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa@redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi@eldorado.org.br> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: anmolbabu <anbabu@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server