Eli Mesika has submitted this change and it was merged. Change subject: core: creating pool when there is not enough space ...................................................................... core: creating pool when there is not enough space Adding a new configuration variable : VmPoolMaxSubsequentFailures (defaulted to 3) This limits the number of subsequent failures in vm creation in a pool to the configured number After reaching this number, vm creation loop will stop generating a audit log messages determining the reason of failure and how many vms from requested were created. Keep in mind that we count only subsequent failures. The reason for that is that we may have a temporary problem on a certain VM, so if a VM creation is failed we continue the loop and advance the subsequent failures counter and if a VM creation succeeded we reset this counter. Change-Id: I76d485c85e609f4cbea7e2fd37c90937e792c00d Signed-off-by: Eli Mesika <emesika@redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/tools/engine-config/src/main/resources/engine-config.properties 7 files changed, 32 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76d485c85e609f4cbea7e2fd37c90937e792c00d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra@linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>