Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: toString return null ...................................................................... findbugs: toString return null its a bad practice and may cause to runtime exception when returning null in toString() findbugs reason NP: toString method may return null (NP_TOSTRING_COULD_RETURN_NULL) Change-Id: Ib7385775b938054a5fd713c458706271b20573ad Signed-off-by: Shahar Havivi <shavivi(a)redhat.com&gt; --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Uri.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/UriAuthority.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/UriTest.java 4 files changed, 8 insertions(+), 10 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7385775b938054a5fd713c458706271b20573ad Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com&gt; Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt; Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;