Maor Lipchuk has submitted this change and it was merged. Change subject: core:Import VM should not be blocked when collapse.(#766657) ...................................................................... core:Import VM should not be blocked when collapse.(#766657) https://bugzilla.redhat.com/766657 Import VM to block domain should be blocked only for images which have sparse volume type and RAW volume format. Block storage domains do not support RAW sparse volumes, so those disks can not be imported to ISCSI domain. If user will choose to copy collapse the VM images, he can choose to override the disks configuration to be cow sparse or raw preallocated, which are supported by the target block storage domains, and the VM can be imported. The proposed fix, performs the validation on the configuration, in two cases: 1. When user sends copy collapse indication as true, and chooses a valid configuration for volume format and type for storage domain. 2. when user imports a VM with valid disks configuration without copy collapse. Signed-off-by: Maor Lipchuk <mlipchuk@redhat.com> Change-Id: Ic6f4b762fbd9770c5157fee6b24373fa9a0dca10 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 18 insertions(+), 5 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6f4b762fbd9770c5157fee6b24373fa9a0dca10 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf@redhat.com> Gerrit-Reviewer: Ayal Baron <abaron@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com>