Allon Mureinik has submitted this change and it was merged. Change subject: core: check if duplicate storage connection exists ...................................................................... core: check if duplicate storage connection exists Check in Add/Update storage connection whether a duplicate storage connection already exists. The check was already present only for file domains in AddStorageConnection command, and now it is expanded to check for block domains as well, and is also used now by the UpdateStorageServerConnection. Also moved the code to a parent command to allow code reuse, and added corresponding unitests. Change-Id: I0cfc642c49ab4fc482c5d1fabc28fad0ae79d2f4 Signed-off-by: Alissa Bonas <abonas@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommandTest.java 5 files changed, 172 insertions(+), 36 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cfc642c49ab4fc482c5d1fabc28fad0ae79d2f4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas@redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server