Alona Kaplan has submitted this change and it was merged. Change subject: core: do not validate free mac addresses when importing template ...................................................................... core: do not validate free mac addresses when importing template When importing template it's not needed to make sure there are enough of macs in pool. Until we create VM out of this template no nics will be needed, so this too-early check may falsely succeed and falsely fail. Also when pool is also bound to VmPool check of free macs for template would not be possible(or at least sane), since we do not know, what pool will be used, and we may end up checking in wrong pool. Change-Id: I1c568ce28dc901ef89416473ef0cf960f3276b1e Signed-off-by: Martin Mucha <mmucha@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicMacsUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommandTest.java 4 files changed, 25 insertions(+), 23 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c568ce28dc901ef89416473ef0cf960f3276b1e Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>