Itamar Heim has submitted this change and it was merged. Change subject: tools: notifier: smtp: collapse JavaMailSender into transport ...................................................................... tools: notifier: smtp: collapse JavaMailSender into transport transport is all about sending smtp, there is no need for cross class access and multiple configuration access. Change-Id: I5082144693689c4feebb9c7e3be9bffaf75b8d72 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com&gt; --- D backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/JavaMailSender.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java 2 files changed, 125 insertions(+), 165 deletions(-) Approvals: Eli Mesika: Looks good to me, approved mooli tayer: Verified -- To view, visit http://gerrit.ovirt.org/24701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5082144693689c4feebb9c7e3be9bffaf75b8d72 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com&gt; Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com&gt; Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt; Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com&gt; Gerrit-Reviewer: oVirt Jenkins CI Server