Omer Frenkel has submitted this change and it was merged. Change subject: core: extract memory images removal on remove vm out of transaction ...................................................................... core: extract memory images removal on remove vm out of transaction On remove vm command, the data we remove from the DB is being removed inside a transaction. The memory images removal, which is a vdsm operation, is also made inside this trasaction and this is wrong - vdsm operations should be executed out of transactions. So this patch extract the call to vdsm for removing the memory images which is taking place as part of remove vm command to be executed out of transaction. Change-Id: I908f8e9fe4e276063aa88357c3cbfe9ae56be501 Bug-Url: https://bugzilla.redhat.com/985410 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 4 files changed, 73 insertions(+), 72 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I908f8e9fe4e276063aa88357c3cbfe9ae56be501 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server