Muli Salem has submitted this change and it was merged. Change subject: core: Prevent Repetetive Static Ip (#839199) ...................................................................... core: Prevent Repetetive Static Ip (#839199) https://bugzilla.redhat.com/839199 Use reference Collection instead of HashSet, move inner class to end of file, add comment to empty method. Signed-off-by: Muli Salem <msalem@redhat.com> Change-Id: I2839816e890989c6512162640e356189781c1e63 --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NoRepetitiveStaticIpInListConstraint.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/NoRepetitiveStaticIpInListConstraintTest.java 2 files changed, 13 insertions(+), 11 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2839816e890989c6512162640e356189781c1e63 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni@redhat.com> Gerrit-Reviewer: Muli Salem <msalem@redhat.com>