Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: avoid adding HE iSCSI/FC lun as direct LUN ...................................................................... packaging: setup: avoid adding HE iSCSI/FC lun as direct LUN In the past we were adding HE iSCSI/FC LUNs as direct LUN to prevent any weird behviour trying to manually import it into the engine. After https://gerrit.ovirt.org/#/c/46515/ it's not needed anymore. Open point: how to correctly remove the fake DirectLUN in 3.5 -> 3.6 upgrade on iSCSI. Change-Id: Ic36aba660c218df723338bd552e3d269ab94d7db Depends-On: https://gerrit.ovirt.org/#/c/46515/ Bug-Url: https://bugzilla.redhat.com/1273378 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com> --- M po/POTFILES.in M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/engine/Makefile.am M src/plugins/ovirt-hosted-engine-setup/engine/__init__.py D src/plugins/ovirt-hosted-engine-setup/engine/add_disk.py 5 files changed, 0 insertions(+), 229 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic36aba660c218df723338bd552e3d269ab94d7db Gerrit-PatchSet: 10 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde@redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>