Change in ovirt-engine[master]: engine: Detach RemoveImage from MoveDisk command

From Allon Mureinik <amureini@redhat.com>:
Allon Mureinik has submitted this change and it was merged. Change subject: engine: Detach RemoveImage from MoveDisk command ...................................................................... engine: Detach RemoveImage from MoveDisk command At the end of the MoveImageGroupCommand, a RemoveImage command is called to clean the source disk. In the case the RemoveImage is taking long to finish, the Job of the MoveImageGroupCommand could be cleared meanwhile and when the RemoveImage command will try to update its step it will fail to find the Job entry causing an SQL exception. In order to avoid this situation, the RemoveImage command will be executed in a new context. Note that its execution will not be reported in the UI. Change-Id: I86deaf1f3d716e28e76236c73f13c830b3c7338d Bug-Url: https://bugzilla.redhat.com/1464348 Signed-off-by: Fred Rolland <frolland@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/MoveImageGroupCommand.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Benny Zlotnik: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/78775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86deaf1f3d716e28e76236c73f13c830b3c7338d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Fred Rolland <frolland@redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
Code Review